kbendick commented on code in PR #4811:
URL: https://github.com/apache/iceberg/pull/4811#discussion_r876544211
##########
python/src/iceberg/expressions/literals.py:
##########
@@ -44,13 +44,7 @@
TimeType,
UUIDType,
)
-from iceberg.utils.datetime import (
Review Comment:
I somewhat agree in this case, but I'm of the opinion that if this is how
`black` / the formatting tool formats, we should choose to opt for the chosen
default styles unless the change is really glaring.
I imagine there's a limit we can maybe configure but 4 is arguably enough to
use this format. At 6 or so I would definitely prefer this style.
My understanding is that this is an area where convention (as dictated by
the tool) is usually preferred over configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
