samredai commented on code in PR #4811: URL: https://github.com/apache/iceberg/pull/4811#discussion_r879668588
########## python/tests/io/test_pyarrow.py: ########## @@ -139,7 +138,7 @@ def test_raise_on_opening_a_local_file_not_found(): def test_raise_on_opening_a_local_file_no_permission(): - """Test that a PyArrowFile raises appropriately when opening a local file without permission""" + """Test that a PyArrowFile raises appropriately when creating a local file without permission""" Review Comment: I think this should be kept to "opening" right? The test is creating a temp directory with locked down permissions, and then asserting that the right exception is raised when trying to open a file in that directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
