samredai commented on code in PR #4811: URL: https://github.com/apache/iceberg/pull/4811#discussion_r879664097
########## python/src/iceberg/io/pyarrow.py: ########## @@ -26,10 +26,15 @@ from typing import Union from urllib.parse import urlparse +from iceberg.io.base import ( + FileIO, + InputFile, + InputStream, + OutputFile, + OutputStream, +) from pyarrow.fs import FileInfo, FileSystem, FileType -from iceberg.io.base import FileIO, InputFile, InputStream, OutputFile, OutputStream Review Comment: It looks like the isort settings haven't been changed, but the autoformatter seems to have grouped local application imports with third party imports. Is there a way we make this stick to the [PEP8 imports](https://peps.python.org/pep-0008/#imports) recommendation? > Imports should be grouped in the following order: > > 1. Standard library imports. > 2. Related third party imports. > 3. Local application/library specific imports. > > You should put a blank line between each group of imports. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
