rdblue commented on code in PR #5672:
URL: https://github.com/apache/iceberg/pull/5672#discussion_r962039298
##########
python/pyiceberg/table/metadata.py:
##########
@@ -128,13 +138,13 @@ def construct_refs(cls, data: Dict[str, Any]):
schemas: List[Schema] = Field(default_factory=list)
"""A list of schemas, stored as objects with schema-id."""
- current_schema_id: int = Field(alias="current-schema-id",
default=DEFAULT_SCHEMA_ID)
+ current_schema_id: int = Field(alias="current-schema-id",
default=INITIAL_SCHEMA_ID)
Review Comment:
These probably shouldn't have defaults because they need to be explicitly
set to some ID that exists in the list of schemas, specs, or sort orders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
