rdblue commented on code in PR #5672:
URL: https://github.com/apache/iceberg/pull/5672#discussion_r962039789
##########
python/pyiceberg/table/partitioning.py:
##########
@@ -82,19 +82,16 @@ class PartitionSpec(IcebergBaseModel):
fields(List[PartitionField): list of partition fields to produce
partition values
"""
- spec_id: int = Field(alias="spec-id")
- fields: Tuple[PartitionField, ...] = Field(default_factory=tuple)
+ spec_id: int = Field(alias="spec-id", default=INITIAL_PARTITION_SPEC_ID)
Review Comment:
I think I'd prefer to handle ID assignment manually rather than defaulting.
Defaulting seems to bring in complexity because if we forget to pass along an
ID somewhere, it would cause problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
