rdblue commented on code in PR #5672: URL: https://github.com/apache/iceberg/pull/5672#discussion_r962039623
########## python/pyiceberg/table/partitioning.py: ########## @@ -29,7 +29,7 @@ from pyiceberg.transforms import Transform from pyiceberg.utils.iceberg_base_model import IcebergBaseModel -INITIAL_SPEC_ID = 0 +INITIAL_PARTITION_SPEC_ID = 1 Review Comment: I think it's a good idea to start assigning spec IDs at 1 and reserve 0 for unpartitioned, but there's no requirement in the spec to do that. Plus, it would be a breaking change so we can't really fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
