rdblue commented on code in PR #5734:
URL: https://github.com/apache/iceberg/pull/5734#discussion_r967892489
##########
api/src/main/java/org/apache/iceberg/Snapshot.java:
##########
@@ -210,12 +154,24 @@ default Iterable<DeleteFile> removedDeleteFiles(FileIO
io) {
}
/**
- * Return the location of this snapshot's manifest list, or null if it is
not separate.
+ * Return the location of this snapshot's manifest list, or null if it is
not separate. If this
+ * method returns null, then {@link Snapshot#v1ManifestLocations()} must
return non-null.
*
* @return the location of the manifest list for this Snapshot
*/
String manifestListLocation();
+ /**
+ * Returns a collection of different manifest locations for this Snapshot,
or null if manifests
+ * are tracked in a single manifest list file (thus {@link
Snapshot#manifestListLocation()} must
+ * return non-null).
+ *
+ * @return A collection of different manifest locations for this Snapshot
+ */
+ default List<String> v1ManifestLocations() {
Review Comment:
I don't see a reason to add this method to the API. The existing methods
should be fine for returning these. It doesn't matter where the manifests are
tracked to callers.
Looks like this is only used for writing manifests in the metadata file as
paths, which can be done using `allManifests`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
