nastra commented on code in PR #5734:
URL: https://github.com/apache/iceberg/pull/5734#discussion_r978406424
##########
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##########
@@ -158,20 +161,64 @@ static Snapshot fromJson(FileIO io, JsonNode node) {
} else {
// fall back to an embedded manifest list. pass in the manifest's
InputFile so length can be
// loaded lazily, if it is needed
- List<ManifestFile> manifests =
- Lists.transform(
- JsonUtil.getStringList(MANIFESTS, node),
- location -> new GenericManifestFile(io.newInputFile(location),
0));
Review Comment:
@rdblue do we want to use the `DUMMY_FILE_IO` instance here as well and keep
eagerly reading the manifest file locations? Then we could also remove the
internal `v1ManifestLocations` variable from `BaseSnapshot`. Let me know what
you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
