nastra commented on code in PR #5734:
URL: https://github.com/apache/iceberg/pull/5734#discussion_r978391410
##########
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##########
@@ -80,8 +77,8 @@ static void toJson(Snapshot snapshot, JsonGenerator
generator) throws IOExceptio
} else {
// embed the manifest list in the JSON, v1 only
generator.writeArrayFieldStart(MANIFESTS);
- for (ManifestFile file : snapshot.allManifests()) {
- generator.writeString(file.path());
+ for (String location : snapshot.v1ManifestLocations()) {
Review Comment:
As discussed in
https://github.com/apache/iceberg/pull/5773#discussion_r978390263 I changed
this to use a fake FileIO to retrieve the paths
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
