ajantha-bhat commented on code in PR #5860:
URL: https://github.com/apache/iceberg/pull/5860#discussion_r981935957
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteManifestsProcedure.java:
##########
@@ -75,6 +96,79 @@ public void testRewriteLargeManifests() {
"Must have 4 manifests", 4,
table.currentSnapshot().allManifests(table.io()).size());
}
+ @Test
+ public void testRewriteLargeManifestsWithDateOrTimestampPartitionedTables() {
+ String[] scenarios = new String[] {"true", "false"};
+ String[] partitionColTypes = new String[] {"DATE", "TIMESTAMP"};
+ for (String scenario : scenarios) {
Review Comment:
Thanks for adding now. Testcase cover all the scenarios.
Instead of these two for loops, we can use Junit's `ParameterizedTest` with
`CsvSource`, it will be very clean compared to this. (as we already depend on
Junit5)
Example:
https://github.com/projectnessie/nessie/blob/main/clients/spark-extensions-basetests/src/main/java/org/projectnessie/spark/extensions/AbstractNessieSparkSqlExtensionTest.java#L589-L596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
