singhpk234 commented on code in PR #5860:
URL: https://github.com/apache/iceberg/pull/5860#discussion_r981970743
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteManifestsProcedure.java:
##########
@@ -75,6 +96,79 @@ public void testRewriteLargeManifests() {
"Must have 4 manifests", 4,
table.currentSnapshot().allManifests(table.io()).size());
}
+ @Test
+ public void testRewriteLargeManifestsWithDateOrTimestampPartitionedTables() {
+ String[] scenarios = new String[] {"true", "false"};
+ String[] partitionColTypes = new String[] {"DATE", "TIMESTAMP"};
+ for (String scenario : scenarios) {
Review Comment:
> Instead of these two for loops, we can use Junit's ParameterizedTest with
CsvSource, it will be very clean compared to this. (as we already depend on
Junit5)
+1 on the suggestion
I tried making this UT a parameterized test as per last feedback, but this
UT didn't ran when i ran the complete suite, I think this is happening due to
`SparkCatalogTestBase` already running with a parameterized class and we
extending that.
https://github.com/apache/iceberg/blob/a8b67085e671bb5fa5a7f738ce2e9cb2dcc65d9c/spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/SparkCatalogTestBase.java#L27
Let me dig in more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
