singhpk234 commented on code in PR #5860:
URL: https://github.com/apache/iceberg/pull/5860#discussion_r997874540
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteManifestsProcedure.java:
##########
@@ -75,6 +96,79 @@ public void testRewriteLargeManifests() {
"Must have 4 manifests", 4,
table.currentSnapshot().allManifests(table.io()).size());
}
+ @Test
+ public void testRewriteLargeManifestsWithDateOrTimestampPartitionedTables() {
+ String[] scenarios = new String[] {"true", "false"};
+ String[] partitionColTypes = new String[] {"DATE", "TIMESTAMP"};
+ for (String scenario : scenarios) {
Review Comment:
I read though the JUnit's code since, to deep dive on observed behaviour, we
are using Parametrized class via SparkCatalogTestBase which by default uses
[BlockJUnit4ClassRunnerWithParametersFactory](https://github.com/junit-team/junit4/blob/main/src/main/java/org/junit/runners/Parameterized.java#L270)
, which in turn uses
[BlockJUnit4ClassRunner#computeTestMethods](https://github.com/junit-team/junit4/blob/main/src/main/java/org/junit/runners/BlockJUnit4ClassRunner.java#L138-L145)
which only runs tests annotated with `@Test` annotation, hence
`@ParamertizedTest` annotated method is being skipped and are not run. will
have to override the factory and runner via
[UseParametersRunnerFactory](https://junit.org/junit4/javadoc/4.12/org/junit/runners/Parameterized.UseParametersRunnerFactory.html).
Was thinking if it's something worth adding, considering the ROI, really
appreciate your feedback's here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
