rdblue commented on code in PR #6072:
URL: https://github.com/apache/iceberg/pull/6072#discussion_r1030777117
##########
core/src/main/java/org/apache/iceberg/BaseIncrementalScan.java:
##########
@@ -82,17 +107,43 @@ public CloseableIterable<T> planFiles() {
schema(),
false /* from snapshot ID inclusive */));
} else {
+ fromSnapshotId = SnapshotUtil.oldestAncestorOf(table(),
toSnapshotIdInclusive).snapshotId();
Listeners.notifyAll(
new IncrementalScanEvent(
table().name(),
- SnapshotUtil.oldestAncestorOf(table(),
toSnapshotIdInclusive).snapshotId(),
+ fromSnapshotId,
toSnapshotIdInclusive,
filter(),
schema(),
true /* from snapshot ID inclusive */));
}
- return doPlanFiles(fromSnapshotIdExclusive, toSnapshotIdInclusive);
+ List<Integer> projectedFieldIds =
Lists.newArrayList(TypeUtil.getProjectedIds(schema()));
+ List<String> projectedFieldNames =
+
projectedFieldIds.stream().map(schema()::findColumnName).collect(Collectors.toList());
Review Comment:
Should this be a helper method in `TypeUtil`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
