rdblue commented on code in PR #6072:
URL: https://github.com/apache/iceberg/pull/6072#discussion_r1030782958


##########
core/src/main/java/org/apache/iceberg/BaseIncrementalChangelogScan.java:
##########
@@ -153,6 +156,9 @@ public CloseableIterable<ChangelogScanTask> apply(
             int changeOrdinal = snapshotOrdinals.get(commitSnapshotId);
             DataFile dataFile = entry.file().copy(context.shouldKeepStats());
 
+            context.scanMetrics().resultDataFiles().increment();

Review Comment:
   This doesn't quite seem accurate to me. These are resulting data files, but 
some of them are used for deletes. Should we split this counter by task type?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to