rdblue commented on code in PR #6072:
URL: https://github.com/apache/iceberg/pull/6072#discussion_r1044897257
##########
core/src/main/java/org/apache/iceberg/BaseIncrementalChangelogScan.java:
##########
@@ -165,6 +170,13 @@ public CloseableIterable<ChangelogScanTask> apply(
context.residuals());
case DELETED:
+ // TODO: this is currently not accurate, rather than counting
delete files, we
+ // should use/have a dimensional counter by "task type" here
Review Comment:
I think what we report here will function as a contract, so we should get it
right the first time around. I'm not convinced that we necessarily need to use
a dimensional counter, but if that's what you want to do I'd prefer that to
reusing a different counter temporarily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
