jackye1995 commented on code in PR #7066:
URL: https://github.com/apache/iceberg/pull/7066#discussion_r1134374843
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -1249,6 +1279,22 @@ private boolean s3KeyIdAccessKeyBothConfigured() {
return (s3AccessKeyId == null) == (s3SecretAccessKey == null);
}
+ private AwsCredentialsProvider credentialsProvider(String
credentialsProviderClazz) {
+ try {
+ AwsCredentialsProvider provider =
+
DynMethods.builder("create").impl(credentialsProviderClazz).buildChecked().invoke(null);
Review Comment:
if it's always invoking null, then why not just initialize the client using
an empty constructor? We might want to pass in configs of the client using
properties with `client.credential-provider.` prefix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
