dpaani commented on code in PR #7066:
URL: https://github.com/apache/iceberg/pull/7066#discussion_r1136435678
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -1249,6 +1279,22 @@ private boolean s3KeyIdAccessKeyBothConfigured() {
return (s3AccessKeyId == null) == (s3SecretAccessKey == null);
}
+ private AwsCredentialsProvider credentialsProvider(String
credentialsProviderClazz) {
+ try {
+ AwsCredentialsProvider provider =
+
DynMethods.builder("create").impl(credentialsProviderClazz).buildChecked().invoke(null);
Review Comment:
@jackye1995 I added support for both create() and create(Map<String, String)
method from the provider class. If no properties set, it will call create(),
else create(Map). Most of the AWS SDK Credential Providers are using create()
method instead of constructor and thats why I followed this approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
