dpaani commented on code in PR #7066:
URL: https://github.com/apache/iceberg/pull/7066#discussion_r1136436652
##########
aws/src/test/java/org/apache/iceberg/aws/TestAwsClientFactories.java:
##########
@@ -132,6 +136,41 @@ public void
testLakeFormationAwsClientFactorySerializable() throws IOException {
.isInstanceOf(LakeFormationAwsClientFactory.class);
}
+ @Test
+ public void testDefaultAwsClientFactoryWithCredentialsProvider() {
+ Map<String, String> properties = Maps.newHashMap();
+ properties.put(AwsProperties.AWS_REGION, Region.AWS_GLOBAL.toString());
+ properties.put(
+ AwsProperties.S3FILEIO_CREDENTIALS_PROVIDER,
+ SystemPropertyCredentialsProvider.class.getName());
Review Comment:
@RussellSpitzer Added `Class.forName` to check class exists in the
classpath. Please check. I could not find any existing API in iceberg project
Spark `Utils.classIsLoadable` API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
