dpaani commented on code in PR #7066:
URL: https://github.com/apache/iceberg/pull/7066#discussion_r1140470269
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -1071,8 +1118,12 @@ public Map<String, String> httpClientProperties() {
* </pre>
*/
public <T extends S3ClientBuilder> void applyS3CredentialConfigurations(T
builder) {
- builder.credentialsProvider(
- credentialsProvider(s3AccessKeyId, s3SecretAccessKey, s3SessionToken));
+ if (this.s3CredentialsProvider != null &&
this.s3CredentialsProvider.trim().length() > 0) {
+
builder.credentialsProvider(credentialsProvider(this.s3CredentialsProvider.trim()));
Review Comment:
Just added in case if a user makes a config mistake by adding space. Removed
now.
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -629,6 +654,8 @@ public class AwsProperties implements Serializable {
public static final String LAKE_FORMATION_DB_NAME = "lakeformation.db-name";
private static final String HTTP_CLIENT_PREFIX = "http-client.";
+
+ private static final String CREDENTIAL_PROVIDER_PREFIX =
"client.credentials-provider.";
Review Comment:
Added newline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
