dpaani commented on code in PR #7066:
URL: https://github.com/apache/iceberg/pull/7066#discussion_r1140430045


##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -1249,6 +1314,39 @@ private boolean s3KeyIdAccessKeyBothConfigured() {
     return (s3AccessKeyId == null) == (s3SecretAccessKey == null);
   }
 
+  private AwsCredentialsProvider credentialsProvider(String 
credentialsProviderClazz) {

Review Comment:
   Thanks @RussellSpitzer .  I am fine with your approach. Once @jackye1995 
approves, I can add it.
   
   hi @jackye1995 These are some of the AWS SDK provided credentials provider 
classes
   
   ```
   software.amazon.awssdk.auth.credentials.AnonymousCredentialsProvider
   
software.amazon.awssdk.auth.credentials.EnvironmentVariableCredentialsProvider
   software.amazon.awssdk.auth.credentials.SystemPropertyCredentialsProvider
   
software.amazon.awssdk.auth.credentials.WebIdentityTokenFileCredentialsProvider
   ```
   
   AWS SDK V2 Apis not using constructors in most of the cases. 
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to