jackye1995 commented on code in PR #7066:
URL: https://github.com/apache/iceberg/pull/7066#discussion_r1139271269
##########
aws/src/test/java/org/apache/iceberg/aws/TestAwsClientFactories.java:
##########
@@ -132,6 +136,41 @@ public void
testLakeFormationAwsClientFactorySerializable() throws IOException {
.isInstanceOf(LakeFormationAwsClientFactory.class);
}
+ @Test
+ public void testDefaultAwsClientFactoryWithCredentialsProvider() {
+ Map<String, String> properties = Maps.newHashMap();
+ properties.put(AwsProperties.AWS_REGION, Region.AWS_GLOBAL.toString());
+ properties.put(
+ AwsProperties.S3FILEIO_CREDENTIALS_PROVIDER,
+ SystemPropertyCredentialsProvider.class.getName());
Review Comment:
+1 for making a fake class for this. See examples like
https://github.com/apache/iceberg/blob/master/core/src/test/java/org/apache/iceberg/TestLocationProvider.java#L185
And do we need `Class.forName`? I think it will naturally throw
ClassNotFound in `DynMethods`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
