[ 
https://issues.apache.org/jira/browse/IGNITE-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454870#comment-16454870
 ] 

Pavel Tupitsyn commented on IGNITE-8075:
----------------------------------------

[~ivandasch] I agree with FxCop here. We do not expect a failure there, no need 
to catch any exceptions.
The {{Dispose method should not throw an exception}} rule is mostly about 
explicit {{throw}} or some expected exceptions.

If current Dispose method throws we are screwed anyway, because something has 
went very wrong. Trying to hide this will do no good.

> .NET: setRollbackOnTopologyChangeTimeout, withLabel, localActiveTransactions, 
> setTxTimeoutOnPartitionMapExchange
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-8075
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8075
>             Project: Ignite
>          Issue Type: Improvement
>    Affects Versions: 2.4
>            Reporter: Alexei Scherbakov
>            Assignee: Ivan Daschinskiy
>            Priority: Major
>             Fix For: 2.6
>
>
> Neet to add new methods as part of .NET API:
> org.apache.ignite.configuration.TransactionConfiguration#txTimeoutOnPartitionMapExchange
>  - timeout for automatic rollback on exchange.
> org.apache.ignite.IgniteTransactions#withLabel - tx label
> org.apache.ignite.IgniteTransactions#localActiveTransactions - list of local 
> active transactions.
> org.apache.ignite.IgniteCluster#setTxTimeoutOnPartitionMapExchange
> Java implementation is currently available at a branch [1]
> [1] https://github.com/gridgain/apache-ignite/tree/ignite-6827-2



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to