PokIsemaine opened a new pull request, #2230: URL: https://github.com/apache/kvrocks/pull/2230
* issues: https://github.com/apache/kvrocks/issues/1952 I'm trying to support the `sort` command and later the `sort_ro` command for kvrocks, this is my first time submitting a pull request for this project and I need some advice, so I set it to draft temporarily. The help I need is as follows： * There are three TODOs in the code and I don’t know how to deal with them. It seems that they are related to `ACL`, `Cluster`, `CLIENT_SCRIPT`, but I have not found relevant support for kvrocks at present. What should I do? The following is the relevant code in the redis implementation: * TODO1: https://github.com/redis/redis/blob/f4481e657f905074fa515701af3f695757817d88/src/sort.c#L237 * TODO2: https://github.com/redis/redis/blob/f4481e657f905074fa515701af3f695757817d88/src/sort.c#L218 * TODO3: https://github.com/redis/redis/blob/f4481e657f905074fa515701af3f695757817d88/src/sort.c#L296 * How to support `denyoom` and `movablekeys` flags, or whether kvrocks needs to support it? ``` 127.0.0.1:6379> command info sort 1) 1) "sort" 2) (integer) -2 3) 1) write 2) denyoom 3) movablekeys ``` * Whether there is any need to modify or add to the existing code (especially exceptions), comments, and tests (especially boundary cases) in the draft? If you can provide me with any advice I would be very grateful！ The information and code I referenced are as follows: * [1] https://redis.io/commands/sort/ * [2] https://redis.io/commands/sort_ro/ * [3] https://github.com/redis/redis/blob/unstable/src/sort.c imitate its implementation * [4] Execute `command docs sort` and `command info sort` to obtain the parameters, flags and other information of the sort command -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
