PokIsemaine commented on PR #2230: URL: https://github.com/apache/kvrocks/pull/2230#issuecomment-2056967186
> @PokIsemaine Thanks for your PR. Your code is amazingly clean. The test cases are also very detailed. For these TODO comments, I think we can keep them. > > The logic LGTM. But according to our conventions, this command should be placed in the `cmd_key.cc` file, and the core logic of the Execute function should be extracted and placed in the `redis::Database` class. > > Below is a example: > > https://github.com/apache/kvrocks/blob/26cbdb978b53c08216c6dfb5d45ed950ccde5936/src/commands/cmd_key.cc#L138-L149 Thanks for the advice, I'll probably do it this weekend -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
