PragmaTwice commented on code in PR #2230:
URL: https://github.com/apache/kvrocks/pull/2230#discussion_r1564411960
##########
src/commands/commander.h:
##########
@@ -185,6 +187,10 @@ inline uint64_t ParseCommandFlags(const std::string
&description, const std::str
flags |= kCmdCluster;
else if (flag == "no-dbsize-check")
flags |= kCmdNoDBSizeCheck;
+ else if (flag == "deny-oom")
+ flags |= kCmdDenyOom;
Review Comment:
I think we don't plan to implement it in this PR, so please remove it.
##########
src/commands/commander.h:
##########
@@ -65,6 +65,8 @@ enum CommandFlags : uint64_t {
kCmdROScript = 1ULL << 10, // "ro-script" flag for read-only script
commands
kCmdCluster = 1ULL << 11, // "cluster" flag
kCmdNoDBSizeCheck = 1ULL << 12, // "no-dbsize-check" flag
+ kCmdDenyOom = 1ULL << 13, // "deny-oom" flag
+ kCmdMovableKeys = 1ULL << 14, // "movable-keys" flag
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
