[
https://issues.apache.org/jira/browse/KYLIN-3399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517766#comment-16517766
]
ASF GitHub Bot commented on KYLIN-3399:
---------------------------------------
codecov-io commented on issue #156: KYLIN-3399, makes the code that added in
KYLIN-2474 more intuitive.
URL: https://github.com/apache/kylin/pull/156#issuecomment-398614964
# [Codecov](https://codecov.io/gh/apache/kylin/pull/156?src=pr&el=h1) Report
> Merging [#156](https://codecov.io/gh/apache/kylin/pull/156?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/kylin/commit/01df768ac5f38cbeaff1f3a6245c26a8863d5709?src=pr&el=desc)
will **increase** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/kylin/pull/156?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #156 +/- ##
============================================
+ Coverage 22.39% 22.39% +<.01%
Complexity 4139 4139
============================================
Files 1032 1032
Lines 62261 62264 +3
Branches 8922 8922
============================================
+ Hits 13946 13947 +1
- Misses 46998 47000 +2
Partials 1317 1317
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/156?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[.../apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://codecov.io/gh/apache/kylin/pull/156/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2NsaS9EaWN0aW9uYXJ5R2VuZXJhdG9yQ0xJLmphdmE=)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/156/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh)
| `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
|
[...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/156/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==)
| `78.37% <0%> (+5.4%)` | `6% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/156?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/156?src=pr&el=footer). Last
update
[01df768...ea10331](https://codecov.io/gh/apache/kylin/pull/156?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Leaked lookup table in DictionaryGeneratorCLI#processSegment
> ------------------------------------------------------------
>
> Key: KYLIN-3399
> URL: https://issues.apache.org/jira/browse/KYLIN-3399
> Project: Kylin
> Issue Type: Bug
> Components: Client - CLI
> Reporter: Ted Yu
> Assignee: jiatao.tao
> Priority: Major
>
> {code}
> for (TableRef lookup : toCheckLookup) {
> logger.info("Checking snapshot of " + lookup);
> JoinDesc join =
> cubeSeg.getModel().getJoinsTree().getJoinByPKSide(lookup);
> cubeMgr.getLookupTable(cubeSeg, join);
> {code}
> The lookup table from the last line doesn't seem to be used.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
