[
https://issues.apache.org/jira/browse/KYLIN-3399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517847#comment-16517847
]
ASF GitHub Bot commented on KYLIN-3399:
---------------------------------------
coveralls edited a comment on issue #156: KYLIN-3399, makes the code that added
in KYLIN-2474 more intuitive.
URL: https://github.com/apache/kylin/pull/156#issuecomment-398615455
## Pull Request Test Coverage Report for [Build
3249](https://coveralls.io/builds/17585836)
* **0** of **5** **(0.0%)** changed or added relevant lines in **1** file
are covered.
* **9** unchanged lines in **4** files lost coverage.
* Overall coverage decreased (**-0.01%**) to **24.508%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
|
[core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://coveralls.io/builds/17585836/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcli%2FDictionaryGeneratorCLI.java#L98)
| 0 | 5 | 0.0%
<!-- | **Total:** | **0** | **5** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
|
[core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java](https://coveralls.io/builds/17585836/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fdatagen%2FColumnGenerator.java#L317)
| 1 | 81.08% |
|
[core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://coveralls.io/builds/17585836/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcli%2FDictionaryGeneratorCLI.java#L105)
| 1 | 0.0% |
|
[core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/17585836/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124)
| 2 | 68.46% |
|
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/17585836/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
| 5 | 77.81% |
<!-- | **Total:** | **9** | | -->
| Totals | [](https://coveralls.io/builds/17585836)
|
| :-- | --: |
| Change from base [Build 3247](https://coveralls.io/builds/17584505): |
-0.01% |
| Covered Lines: | 15260 |
| Relevant Lines: | 62265 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Leaked lookup table in DictionaryGeneratorCLI#processSegment
> ------------------------------------------------------------
>
> Key: KYLIN-3399
> URL: https://issues.apache.org/jira/browse/KYLIN-3399
> Project: Kylin
> Issue Type: Bug
> Components: Client - CLI
> Reporter: Ted Yu
> Assignee: jiatao.tao
> Priority: Major
>
> {code}
> for (TableRef lookup : toCheckLookup) {
> logger.info("Checking snapshot of " + lookup);
> JoinDesc join =
> cubeSeg.getModel().getJoinsTree().getJoinByPKSide(lookup);
> cubeMgr.getLookupTable(cubeSeg, join);
> {code}
> The lookup table from the last line doesn't seem to be used.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
