[ 
https://issues.apache.org/jira/browse/KYLIN-3399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517775#comment-16517775
 ] 

ASF GitHub Bot commented on KYLIN-3399:
---------------------------------------

asfgit commented on issue #156: KYLIN-3399, makes the code that added in 
KYLIN-2474 more intuitive.
URL: https://github.com/apache/kylin/pull/156#issuecomment-398617236
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Leaked lookup table in DictionaryGeneratorCLI#processSegment
> ------------------------------------------------------------
>
>                 Key: KYLIN-3399
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3399
>             Project: Kylin
>          Issue Type: Bug
>          Components: Client - CLI
>            Reporter: Ted Yu
>            Assignee: jiatao.tao
>            Priority: Major
>
> {code}
>         for (TableRef lookup : toCheckLookup) {
>             logger.info("Checking snapshot of " + lookup);
>             JoinDesc join = 
> cubeSeg.getModel().getJoinsTree().getJoinByPKSide(lookup);
>             cubeMgr.getLookupTable(cubeSeg, join);
> {code}
> The lookup table from the last line doesn't seem to be used.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to