atris commented on a change in pull request #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/815#discussion_r326577739
########## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ########## @@ -448,13 +459,42 @@ void assertConsistent() { } } + // pkg-private for testing + // return the list of queries being loaded asynchronously + List<Query> inFlightQueries() { + lock.lock(); + try { + return new ArrayList<>(inFlightAsyncLoadQueries); Review comment: Not all places which access `inFlightAsyncLoadQueries` take a lock -- the main being `cacheAsynchronously` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org