atris commented on a change in pull request #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/815#discussion_r327642580
########## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ########## @@ -832,5 +889,25 @@ public BulkScorer bulkScorer(LeafReaderContext context) throws IOException { return new DefaultBulkScorer(new ConstantScoreScorer(this, 0f, ScoreMode.COMPLETE_NO_SCORES, disi)); } + // Perform a cache load asynchronously + private void cacheAsynchronously(LeafReaderContext context, IndexReader.CacheHelper cacheHelper) { + /* + * If the current query is already being asynchronously cached, + * do not trigger another cache operation + */ + if (inFlightAsyncLoadQueries.add(in.getQuery()) == false) { + return; + } + + FutureTask<Void> task = new FutureTask<>(() -> { + DocIdSet localDocIdSet = cache(context); + putIfAbsent(in.getQuery(), localDocIdSet, cacheHelper); + + //remove the key from inflight -- the key is loaded now + inFlightAsyncLoadQueries.remove(in.getQuery()); + return null; + }); + executor.execute(task); Review comment: That depends on the implementation of the executor passed in -- I think we do not publish any such contract in `IndexSearcher`, and since this is reusing the same `Executor`, the behaviour is the same. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org