atris commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#discussion_r330578984
########## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ########## @@ -732,8 +821,24 @@ public ScorerSupplier scorerSupplier(LeafReaderContext context) throws IOExcepti if (docIdSet == null) { if (policy.shouldCache(in.getQuery())) { - docIdSet = cache(context); - putIfAbsent(in.getQuery(), docIdSet, cacheHelper); + boolean cacheSynchronously = executor == null; + + // If asynchronous caching is requested, perform the same and return + // the uncached iterator + if (cacheSynchronously == false) { + cacheSynchronously = cacheAsynchronously(context, cacheHelper); + + // If async caching failed, synchronous caching will + // be performed, hence do not return the uncached value + if (cacheSynchronously == false) { + return in.scorerSupplier(context); + } + } + + if (cacheSynchronously) { Review comment: We need this to be checked even after async caching since async caching might have failed, in which case we will have to perform a synchronous caching ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org