atris commented on a change in pull request #916: LUCENE-8213: Asynchronous
Caching in LRUQueryCache
URL: https://github.com/apache/lucene-solr/pull/916#discussion_r330579304
##########
File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java
##########
@@ -813,8 +918,23 @@ public BulkScorer bulkScorer(LeafReaderContext context)
throws IOException {
if (docIdSet == null) {
if (policy.shouldCache(in.getQuery())) {
- docIdSet = cache(context);
- putIfAbsent(in.getQuery(), docIdSet, cacheHelper);
+ boolean cacheSynchronously = executor == null;
+ // If asynchronous caching is requested, perform the same and return
+ // the uncached iterator
+ if (cacheSynchronously == false) {
+ cacheSynchronously = cacheAsynchronously(context, cacheHelper);
+
+ // If async caching failed, we will perform synchronous caching
+ // hence do not return the uncached value here
+ if (cacheSynchronously == false) {
Review comment:
Not necessarily -- cacheAsynchronously() might have failed, in which case it
will return a true and this code path will trigger a synchronous caching
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
