cbuescher commented on a change in pull request #913: LUCENE-8995:
TopSuggestDocsCollector#collect should be able to signal rejection
URL: https://github.com/apache/lucene-solr/pull/913#discussion_r332913649
##########
File path:
lucene/suggest/src/java/org/apache/lucene/search/suggest/document/TopSuggestDocs.java
##########
@@ -105,6 +105,10 @@ public TopSuggestDocs(TotalHits totalHits,
SuggestScoreDoc[] scoreDocs, boolean
this.isComplete = isComplete;
}
+ public TopSuggestDocs(TotalHits totalHits, SuggestScoreDoc[] scoreDocs) {
Review comment:
I'm not sure about how bwc is handled in Lucene, especially if we intend to
backport this to maybe 8.x, so I don't know if we need a ctor without the
isComplete flag?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
