cbuescher commented on a change in pull request #913: LUCENE-8995:
TopSuggestDocsCollector#collect should be able to signal rejection
URL: https://github.com/apache/lucene-solr/pull/913#discussion_r335372402
##########
File path:
lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestPrefixCompletionQuery.java
##########
@@ -253,6 +263,123 @@ public void testDocFiltering() throws Exception {
iw.close();
}
+ /**
+ * Test that the correct amount of documents are collected if using a
collector that also rejects documents.
+ */
+ public void testCollectorThatRejects() throws Exception {
+ // use synonym analyzer to have multiple paths to same suggested document.
This mock adds "dog" as synonym for "dogs"
+ Analyzer analyzer = new MockSynonymAnalyzer();
+ RandomIndexWriter iw = new RandomIndexWriter(random(), dir,
iwcWithSuggestField(analyzer, "suggest_field"));
+ List<Entry> expectedResults = new ArrayList<Entry>();
+
+ for (int docCount = 10; docCount > 0; docCount--) {
+ Document document = new Document();
+ String value = "ab" + docCount + " dogs";
+ document.add(new SuggestField("suggest_field", value, docCount));
+ expectedResults.add(new Entry(value, docCount));
+ iw.addDocument(document);
+ }
+
+ if (rarely()) {
+ iw.commit();
+ }
+
+ DirectoryReader reader = iw.getReader();
+ SuggestIndexSearcher indexSearcher = new SuggestIndexSearcher(reader);
+
+ PrefixCompletionQuery query = new PrefixCompletionQuery(analyzer, new
Term("suggest_field", "ab"));
+ int topN = 5;
+
+ // use a TopSuggestDocsCollector that rejects results with duplicate docIds
+ TopSuggestDocsCollector collector = new TopSuggestDocsCollector(topN,
false) {
+
+ private Set<Integer> seenDocIds = new HashSet<>();
+
+ @Override
+ public boolean collect(int docID, CharSequence key, CharSequence
context, float score) throws IOException {
+ int globalDocId = docID + docBase;
+ boolean collected = false;
+ if (seenDocIds.contains(globalDocId) == false) {
Review comment:
The collector is called multiple times with the same docID because of the
MockSynonymAnalyzer used in the test setup which adds "dog" for "dogs", so each
document has two completion paths. This collector is meant to de-duplicate
this. I added a note explaining this. This is a simplified version of the
behaviour we observe in https://github.com/elastic/elasticsearch/issues/46445.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
