msokolov commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r385082544
########## File path: lucene/core/src/java/org/apache/lucene/search/DefaultSliceExecutionControlPlane.java ########## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.lucene.search; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.List; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.Executor; +import java.util.concurrent.Future; +import java.util.concurrent.FutureTask; +import java.util.concurrent.RejectedExecutionException; + +/** + * Implementation of SliceExecutionControlPlane with queue backpressure based thread allocation + */ +public class DefaultSliceExecutionControlPlane implements SliceExecutionControlPlane<List<Future>, FutureTask> { + private final Executor executor; + + public DefaultSliceExecutionControlPlane(Executor executor) { + this.executor = executor; + } + + @Override + public List<Future> invokeAll(Collection<FutureTask> tasks) { + + if (tasks == null) { + throw new IllegalArgumentException("Tasks is null"); + } + + if (executor == null) { + throw new IllegalArgumentException("Executor is null"); + } + + List<Future> futures = new ArrayList(); + + int i = 0; + + for (FutureTask task : tasks) { + boolean shouldExecuteOnCallerThread = false; + + // Execute last task on caller thread + if (i == tasks.size() - 1) { + shouldExecuteOnCallerThread = true; + } + + processTask(task, futures, shouldExecuteOnCallerThread); + ++i; + } + + return futures; + } + + // Helper method to execute a single task + protected void processTask(FutureTask task, List<Future> futures, + boolean shouldExecuteOnCallerThread) { Review comment: The logic around this boolean is hard to read. I think it would be clearer if we restructure the logic a bit and avoid modifying an incoming boolean parameter ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
