dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle
wrapper jar from source
URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400450439
##########
File path: gradlew
##########
@@ -80,6 +80,19 @@ case "`uname`" in
;;
esac
+
+# Loop in case we encounter an error.
Review comment:
This loop should terminate with an error if the wrapper can't be downloaded.
A windows version would also be necessary. The problem is that Windows won't
have curl so some other workaround is needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
