madrob commented on a change in pull request #1390: LUCENE-9266 remove gradle
wrapper jar from source
URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400486453
##########
File path: .github/workflows/gradle-precommit.yml
##########
@@ -19,5 +19,8 @@ jobs:
java-version: 11
- name: Grant execute permission for gradlew
run: chmod +x gradlew
+ - name: Run something to download the gradle wrapper jar
Review comment:
validator will verify the checksum, which I felt was important before we go
on to running the rest of precommit. Maybe my threat model is wrong here? We
can move validator action to after precommit in that case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
