tflobbe commented on a change in pull request #1456:
URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r418750165
##########
File path: solr/core/src/java/org/apache/solr/search/MaxScoreCollector.java
##########
@@ -37,9 +37,7 @@ public float getMaxScore() {
@Override
public ScoreMode scoreMode() {
- // Should be TOP_SCORES but this would wrap the scorer unnecessarily since
- // this collector is only used in a MultiCollector.
- return ScoreMode.COMPLETE;
+ return ScoreMode.TOP_SCORES;
Review comment:
There is a previous discussion in this PR about it:
> tflobbe:
> @jpountz, What did you mean with this comment? MultiCollector will set the
scoreMode to COMPLETE in the case of the main collector being something other
than TOP_SCORES, right?
> jpountz:
> Yeah I think that at some point we tried not to wrap the scorer when all
score modes were COMPLETE but apparently now we do, so this comment is stale.
https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/search/MultiCollector.java#L158
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
