tflobbe commented on a change in pull request #1456:
URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r418756851
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java
##########
@@ -401,6 +403,14 @@ public void process(ResponseBuilder rb) throws IOException
doProcessUngroupedSearch(rb, cmd, result);
}
+ private int getMinExactHits(SolrParams params) {
+ long minExactHits = params.getLong(CommonParams.MIN_EXACT_HITS,
Integer.MAX_VALUE);
+ if (minExactHits < 0 || minExactHits > Integer.MAX_VALUE) {
Review comment:
This is intentional. See the discussion with Adrien in this same PR. We
allow longs just because the `minExactHits` is in relation to the `numFound`,
which is a long, however, any value greater than `Integer.MAX_VALUE` doesn't
make sense, since Lucene doesn't allow more than that in a single shard. In
case of distributed queries, the `minExactHits` is used by every shard
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
