mbwaheed commented on a change in pull request #1430:
URL: https://github.com/apache/lucene-solr/pull/1430#discussion_r425514716
##########
File path:
solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java
##########
@@ -114,16 +104,29 @@
private RollupRequestReplicationTracker rollupReplicationTracker;
private LeaderRequestReplicationTracker leaderReplicationTracker;
+ /**
+ * For {@link Replica.Type#SHARED} replica, it is necessary that we pull
from the shared store at the start of
+ * an indexing batch (if the core is stale). And we push to the shared store
at the end of a successfully committed
+ * indexing batch (we ensure that each batch has a hard commit). Details can
be found in
+ * {@link org.apache.solr.store.shared.SharedCoreConcurrencyController}.
+ * In other words, we would like to call {@link
SharedCoreIndexingBatchProcessor#startIndexingBatch()} at the start of
+ * an indexing batch and {@link
SharedCoreIndexingBatchProcessor#finishIndexingBatch()} at the end of a
successfully
+ * committed indexing batch.
+ * For that, we rely on first {@link #processAdd(AddUpdateCommand)} or
{@link #processCommit(CommitUpdateCommand)}
Review comment:
Thanks for catching. Actually processCommit was incorrectly mentioned in
place of processDelete.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
