mbwaheed commented on a change in pull request #1430:
URL: https://github.com/apache/lucene-solr/pull/1430#discussion_r425526455



##########
File path: 
solr/core/src/test/org/apache/solr/store/shared/SharedCoreConcurrencyTest.java
##########
@@ -595,7 +595,7 @@ private void 
configureTestSharedConcurrencyControllerForProcess(
       public void recordState(String collectionName, String shardName, String 
coreName, SharedCoreStage stage) {
         super.recordState(collectionName, shardName, coreName, stage);
         ConcurrentLinkedQueue<String> coreConcurrencyStages = 
coreConcurrencyStagesMap.computeIfAbsent(coreName, k -> new 
ConcurrentLinkedQueue<>());
-        coreConcurrencyStages.add(Thread.currentThread().getId() + "." + 
stage.name());
+        coreConcurrencyStages.add(Thread.currentThread().getName() + "." + 
stage.name());

Review comment:
       Sorry this is some what irrelevant. Looking through one of test run logs 
I realized in logging if thread has a name then that is logged e.g. puller 
threads. This change is only to help make debugging of this test easier.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to