murblanc commented on pull request #1528: URL: https://github.com/apache/lucene-solr/pull/1528#issuecomment-631131151
Rebased on master. The recent fix to SOLR-14486 solved the failures in the autoscaling sim tests. I'm submitting this officially for review now (moving it out of draft PR). Note there are two tests that are failing (that I marked @Ignore) and that IMO should either be removed or deserve their own separate Jira for fixing (that I will create once this is merged). I suspect fixes are non trivial: - TestZkChroot: I didn't find ways to reasonably start a test server with a different chroot than /solr to test if it's writing data to the right place in ZooKeeper. Played a while with MiniSolrCloudCluster but chroot seems to be quite hard coded deep in the test framework (passing an already chrooted ZK server defeats the purpose). - BasicZkTest (I didn't dig further). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
