murblanc commented on a change in pull request #1528:
URL: https://github.com/apache/lucene-solr/pull/1528#discussion_r429816694



##########
File path: solr/core/src/test/org/apache/solr/cloud/TestZkChroot.java
##########
@@ -27,8 +27,10 @@
 import org.apache.solr.core.CoreContainer;
 import org.junit.After;
 import org.junit.Before;
+import org.junit.Ignore;
 import org.junit.Test;
 
+// TODO: this class tries to test Zookeeper using Solr abstractions, but ZK 
implies the code is running in cloud mode. It doesn't work.

Review comment:
       I agree (on the followup option).
   I tried to see if there's a way to do the chroot on the mini cluster or 
elsewhere but nothing obvious came after an hour or two of hacking, that's why 
I suggest to leave it for later.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to