[ 
https://issues.apache.org/jira/browse/SOLR-12698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143301#comment-17143301
 ] 

Lucene/Solr QA commented on SOLR-12698:
---------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  8s{color} 
| {color:red} SOLR-12698 does not apply to master. Rebase required? Wrong 
Branch? See 
https://wiki.apache.org/solr/HowToContribute#Creating_the_patch_file for help. 
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12698 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12937795/SOLR-12698.patch |
| Console output | 
https://builds.apache.org/job/PreCommit-SOLR-Build/767/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> SolrFeature: no-fq optimisation
> -------------------------------
>
>                 Key: SOLR-12698
>                 URL: https://issues.apache.org/jira/browse/SOLR-12698
>             Project: Solr
>          Issue Type: Sub-task
>          Components: contrib - LTR
>            Reporter: Stanislav Livotov
>            Priority: Major
>         Attachments: SOLR-12698.patch
>
>
> [~slivotov] wrote in SOLR-12688:
> bq. ... SolrFeature was not optimally implemented for the case when no fq 
> parameter was passed. I'm not absolutely sure what was the intention to 
> introduce both q(which is supposed to be a function query) and fq parameter 
> for the same SolrFeature at all(Is there a case when they will be used 
> together ? ), so I decided not to change behavior but just optimize described 
> case ...
> (Please see SOLR-12688 description for overall context and analysis results.)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to