[ 
https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157210#comment-17157210
 ] 

Dawid Weiss commented on SOLR-13939:
------------------------------------

Hi Erick. This annotation (and others from randomizedtesting) is inherited by 
subclasses but is not cumulative. So you could have one annotation on the top 
class (which would be most convenient) but you can't "add or remove" filters in 
subclasses - the redefinition in a subclass is complete.

The best way would be for all of those custom thread filters to be removed... 
The whole point of thread leak detection is to signal that something is 
wrong... once you let threads slip between test cases you can no longer be sure 
of the consistency of behavior.

> Extract any non-gradle related patches (deprecations, URL fixes, etc.) from 
> gradle effort
> -----------------------------------------------------------------------------------------
>
>                 Key: SOLR-13939
>                 URL: https://issues.apache.org/jira/browse/SOLR-13939
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Dawid Weiss
>            Assignee: Erick Erickson
>            Priority: Major
>         Attachments: SOLR-13939.patch, eoe_merged.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to