[ 
https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158792#comment-17158792
 ] 

Erick Erickson commented on SOLR-13939:
---------------------------------------

As per the mailing list response, I think I've found the "smoking gun", I'll 
push a change in a bit.

In ShardLeaderElectionContextBase.java a number of calls like:

new Path(leaderPath).getParent().toString();

were replaced with

Paths.get(leaderPath).getParent().toString();

But the first is a call to a hadoop class that has special Windows handling to 
add a leading slash (not even a backslash!) and the nio Paths class doesn't do 
anything similar.

I think it's wrong to rely on this behavior from org.apache.hadoop.fs.Path in a 
class having nothing at all to do with hdfs, (we're constructing Zookeeper 
paths) but in the interest of getting Windows working again I'll just revert 
that file. I've added comments so we won't trip up here again unknowingly.

Since I don't have a Windows machine to test with, I'll fix/push and we'll have 
to see tomorrow whether it's really the fix.

> Extract any non-gradle related patches (deprecations, URL fixes, etc.) from 
> gradle effort
> -----------------------------------------------------------------------------------------
>
>                 Key: SOLR-13939
>                 URL: https://issues.apache.org/jira/browse/SOLR-13939
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Dawid Weiss
>            Assignee: Erick Erickson
>            Priority: Major
>             Fix For: 8.7
>
>         Attachments: SOLR-13939-misc.patch, SOLR-13939.patch, eoe_merged.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to