risdenk commented on a change in pull request #1712: URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464075185
########## File path: solr/core/src/java/org/apache/solr/util/hll/HLL.java ########## @@ -47,7 +47,7 @@ * <li><a href="https://github.com/aggregateknowledge/postgresql-hll";>postgresql-hll</a>, and</li> * <li><a href="https://github.com/aggregateknowledge/js-hll";>js-hll</a></li> * </ul> - * when <a href="https://github.com/aggregateknowledge/postgresql-hll/blob/master/STORAGE.markdown";>properly serialized</a>. + * when <a href="https://github.com/aggregateknowledge/postgresql-hll/blob/secondaryy/STORAGE.markdown";>properly serialized</a>. Review comment: Is this change correct? Looks like a typo and not sure this should be changed? ########## File path: solr/webapp/web/js/angular/controllers/login.js ########## @@ -241,7 +241,7 @@ solrAdminApp.controller('LoginController', }; }]); -// This function is copied and adapted from MIT-licensed https://github.com/randymized/www-authenticate/blob/master/lib/parsers.js +// This function is copied and adapted from MIT-licensed https://github.com/randymized/www-authenticate/blob/primary/lib/parsers.js Review comment: Not sure this change should be made. Looks like a GitHub repo url ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
