murblanc commented on a change in pull request #1712: URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464111546
########## File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java ########## @@ -1241,33 +1241,33 @@ public void inform(SolrCore core) { numberBackupsToKeep = 0; } @SuppressWarnings({"rawtypes"}) - NamedList slave = (NamedList) initArgs.get("slave"); - boolean enableSlave = isEnabled( slave ); - if (enableSlave) { - currentIndexFetcher = pollingIndexFetcher = new IndexFetcher(slave, this, core); - setupPolling((String) slave.get(POLL_INTERVAL)); - isSlave = true; + NamedList secondary = (NamedList) initArgs.get("secondary"); + boolean enableSecondary = isEnabled( secondary ); + if (enableSecondary) { + currentIndexFetcher = pollingIndexFetcher = new IndexFetcher(secondary, this, core); + setupPolling((String) secondary.get(POLL_INTERVAL)); + isSecondary = true; } @SuppressWarnings({"rawtypes"}) - NamedList master = (NamedList) initArgs.get("master"); - boolean enableMaster = isEnabled( master ); + NamedList primary = (NamedList) initArgs.get("primary"); Review comment: Also same issue in the other direction: if an updated node sends "primary" to a non updated node expecting "master", the non updated node will fail. Maybe we need to send the same data under both "primary" and "master" and the same data under both "secondary" and "slave", and accept either one on the receiving end. I'm not familiar with how this code exactly works so might be off here, but this rename is not internal so must use caution (and test with renamed nodes talking to non renamed nodes, on both roles). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org