murblanc commented on a change in pull request #1712: URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464141895
########## File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java ########## @@ -1241,33 +1241,33 @@ public void inform(SolrCore core) { numberBackupsToKeep = 0; } @SuppressWarnings({"rawtypes"}) - NamedList slave = (NamedList) initArgs.get("slave"); - boolean enableSlave = isEnabled( slave ); - if (enableSlave) { - currentIndexFetcher = pollingIndexFetcher = new IndexFetcher(slave, this, core); - setupPolling((String) slave.get(POLL_INTERVAL)); - isSlave = true; + NamedList secondary = (NamedList) initArgs.get("secondary"); + boolean enableSecondary = isEnabled( secondary ); + if (enableSecondary) { + currentIndexFetcher = pollingIndexFetcher = new IndexFetcher(secondary, this, core); + setupPolling((String) secondary.get(POLL_INTERVAL)); + isSecondary = true; } @SuppressWarnings({"rawtypes"}) - NamedList master = (NamedList) initArgs.get("master"); - boolean enableMaster = isEnabled( master ); + NamedList primary = (NamedList) initArgs.get("primary"); Review comment: As @chatman commented in the general discussion, maybe these changes happening in a new major version branch does no require them to be backward/forward compatible? If 8x and 9.0 servers are expected to talk and understand each other, the suggestion looks good on the receiving end. We need something on the sending end as well (send both values, because "primary" being sent to a 8x server expecting only "master" will not be understood). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org