[ 
https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172050#comment-17172050
 ] 

Robert Muir commented on LUCENE-8626:
-------------------------------------

I'm gonna reiterate my numbers: 2/3 of all tests use the style starting with 
Test*:
{noformat}
lucene-solr[master]$ find . -name "Test*.java"  | wc -l
1739
lucene-solr[master]$ find . -name "*Test.java"  | wc -l
891
{noformat}

Within the lucene test suite, it is nearly 90%. It is really only a few 
activists using a different style:
{noformat}
think:lucene[master]$ find . -name "Test*.java" | wc -l
1215
think:lucene[master]$ find . -name "*Test.java" | wc -l
157
{noformat}

Within the solr test suite, things are less consistent:
{noformat}
think:solr[master]$ find . -name "Test*.java" | wc -l
524
think:solr[master]$ find . -name "*Test.java" | wc -l
734
{noformat}

So I don't think we should use "Test" as a suffix with no scientific reason 
when most tests (especially the ones that work consistently) are doing the 
opposite.


> standardise test class naming
> -----------------------------
>
>                 Key: LUCENE-8626
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8626
>             Project: Lucene - Core
>          Issue Type: Test
>            Reporter: Christine Poerschke
>            Priority: Major
>         Attachments: SOLR-12939.01.patch, SOLR-12939.02.patch, 
> SOLR-12939.03.patch, SOLR-12939_hoss_validation_groovy_experiment.patch
>
>
> This was mentioned and proposed on the dev mailing list. Starting this ticket 
> here to start to make it happen?
> History: This ticket was created as 
> https://issues.apache.org/jira/browse/SOLR-12939 ticket and then got 
> JIRA-moved to become https://issues.apache.org/jira/browse/LUCENE-8626 ticket.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to